Homec4science

Improve column device behaviors

Authored by epriestley <git@epriestley.com> on Mar 28 2015, 14:54.

Description

Improve column device behaviors

Summary:
Fixes T7062. When the column is open, we only want to consider the screen width which is avilable for content when computing responsive breakpoints.

Specificially, if you have a 1000px wide browser window (normally "desktop") but the column is open (300px) so you only have 700px free for content (normally "tablet"), we should drop to the tablet breakpoint. This lets you have a narrow column of "tablet" content next to the chat column, instead of a really squished column of "desktop" contnet.

This also means the chat column can't directly use JX.Device to hide itself.

Test Plan: Resized screen with column open, saw content go from Desktop + Column -> Tablet + Column -> Tablet -> Mobile.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7062

Differential Revision: https://secure.phabricator.com/D12189

Details

Committed
epriestley <git@epriestley.com>Mar 28 2015, 14:54
Pushed
aubortJan 31 2017, 17:16
Parents
rPH21454842bf18: Fix comment previews in Quicksand
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8c1a1312e8c7: Improve column device behaviors (authored by epriestley <git@epriestley.com>).Mar 28 2015, 14:54