Homec4science

Remove calls to DifferentialRevision::loadRelations from commit workers

Authored by Juan Pablo Civile <elementohb@gmail.com> on Jul 16 2013, 03:39.

Description

Remove calls to DifferentialRevision::loadRelations from commit workers

Summary:
Remove ocurrences of loadRelations in workers.

One was simply unnecesary, no subsequent call to getReviewers or getCCPHIDs was made.
The other was replaced with the nicer DifferentialRevisionQuery using needRelations and needReviewerStatus (for future upgrade).

Test Plan:
Land a revision into a tracked repository and check the parser worker attached the commit correctly.
For the owners worker I just checked it didn't crash into a hundred tiny pieces.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D6467

Details

Committed
epriestley <git@epriestley.com>Jul 16 2013, 03:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHee9fac5c8fb7: Use DifferentialRevisionQuery in differential controllers
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8e0a975e3f0f: Remove calls to DifferentialRevision::loadRelations from commit workers (authored by Juan Pablo Civile <elementohb@gmail.com>).Jul 16 2013, 03:39