Homec4science

Make calendar intepret all-day dates in a more consistent way

Authored by epriestley <git@epriestley.com> on Oct 31 2016, 19:51.

Description

Make calendar intepret all-day dates in a more consistent way

Summary:
In ICS, an event on "Nov 1" starts on "2016-11-01" and ends on "2016-11-02".

This is convenient for computers, but this isn't what users expect to enter in date controls. They expect to enter "nov 1" to "Nov 1" for a one-day, all-day event. This is consistent with other applications.

Store the value the user entered, but treat it as the first second of the next day when actually using it if the event is an all day event.

Test Plan:
Mucked around with multi-day all-day events, recurring all-day events, imports, etc. Couldn't catch any weird/unintuitive stuff anymore offhand.

(Previously, entering "Nov 1" to "Nov 2" created a one-day event, which was unclear.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16777

Details

Committed
epriestley <git@epriestley.com>Oct 31 2016, 22:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf7b0c09ac47f: Make the "All Day Event" control use a checkbox instead of a dropdown
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH8e5437226fe9: Make calendar intepret all-day dates in a more consistent way (authored by epriestley <git@epriestley.com>).Oct 31 2016, 22:19