Homec4science

Make the "All Day Event" control use a checkbox instead of a dropdown

Authored by epriestley <git@epriestley.com> on Oct 31 2016, 19:38.

Description

Make the "All Day Event" control use a checkbox instead of a dropdown

Summary:
This feels a little cleaner:

  • Clean up transaction log a bit.
  • Use a checkbox instead of a two-option dropdown.

This is a little messy because the browser doesn't send anything if the user submits a form with an un-clicked checkbox.

We now send a dummy value ("Hey, there's definitely a checkbox in this form!") so the server can figure out what to do.

Test Plan:

  • Edited all-dayness of an event.
  • Viewed transaction log.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D16776

Details

Committed
epriestley <git@epriestley.com>Oct 31 2016, 22:18
Pushed
aubortJan 31 2017, 17:16
Parents
rPH182611ef7e57: Schedule monthly events on the 29th, 30th or 31st relative to the end of the…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf7b0c09ac47f: Make the "All Day Event" control use a checkbox instead of a dropdown (authored by epriestley <git@epriestley.com>).Oct 31 2016, 22:18