Homec4science

Explicitly load assets in revision list

Authored by vrana <jakubv@fb.com> on Aug 17 2012, 21:46.

Description

Explicitly load assets in revision list

Summary:
Rendering method shouldn't load data.
The view probably shouldn't load data either because it is a job for component (object that both loads data and displays them) but we don't have that concept in Phabricator.
This at least improves the architecture a little bit.

Test Plan: /differential/

Reviewers: epriestley

Reviewed By: epriestley

CC: alanh, aran, Korvin

Differential Revision: https://secure.phabricator.com/D3325

Details

Committed
vrana <jakubv@fb.com>Aug 21 2012, 03:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb50cdc6e439c: Highlight update time in revision list
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH8ee2a6f9888e: Explicitly load assets in revision list (authored by vrana <jakubv@fb.com>).Aug 21 2012, 03:02