Homec4science

Conpherence - update the "unread" count in notifications panel aggressively

Authored by Bob Trahan <btrahan@phacility.com> on Mar 17 2015, 21:40.

Description

Conpherence - update the "unread" count in notifications panel aggressively

Summary:
Fixes T7561. Basically everytime we load some transactions in the thread manager, kick off an async thread to update the notification panel.

Should I consolidate this little bit of code into something like this._handleTransactionResponse(r)... ? I just want to keep the JS clear for other engineers and I wasn't sure if that was hiding a bit too much detail.

Test Plan: user a opened durable column. user b sent user a a few messages. reloaded user a page and noted the "N" count became N-1 as the message loaded. Switched messages and saw N-2, N-3, etc as I loaded up the messages.

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T7561

Differential Revision: https://secure.phabricator.com/D12099

Details

Committed
Bob Trahan <btrahan@phacility.com>Mar 17 2015, 21:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7a93b443c3d3: Make file upload policies more consistent
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH8fe78c9029e5: Conpherence - update the "unread" count in notifications panel aggressively (authored by Bob Trahan <btrahan@phacility.com>).Mar 17 2015, 21:40