Homec4science

Add comment previews to Maniphest

Authored by epriestley <git@epriestley.com> on May 10 2011, 17:29.

Description

Add comment previews to Maniphest

Summary:
Moves shared code from Differential and Maniphest comment previews into
PhabricatorShapedRequest, and then implements Maniphest previews.

This doesn't implement comment drafts, I'll follow up with that but it requires
this and is completely separable.

This also always shows the preview as "commented" rather than previewing the
actual transaction. I'll follow up with that but I think it will require a
little factoring and this is useful even without transaction details.

I need to tweak the styling a bit too.

Test Plan:
Typed text in Maniphest and Differential. Toggled Differential action. Made
comments.

Reviewed By: rm
Reviewers: rm, tuomaspelkonen, jungejason, aran
CC: aran, rm
Differential Revision: 258

Details

Committed
epriestley <git@epriestley.com>May 10 2011, 23:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe27c5f26e545: Allow Celerity to return "304 Not Modified" responses
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH90364cafdced: Add comment previews to Maniphest (authored by epriestley <git@epriestley.com>).May 10 2011, 23:35