Homec4science

Allow Celerity to return "304 Not Modified" responses

Authored by epriestley <git@epriestley.com> on May 9 2011, 10:10.

Description

Allow Celerity to return "304 Not Modified" responses

Summary:
We always return HTTP 200 right now and don't send a "Last-Modified" header, so
browsers download more data then necessary if you sit on a page mashing reload
(for example).

Test Plan:
Used Charles to verify HTTP response codes from 400, 404 and 304 responses.

Mashed reload a bunch and saw that the server sent back 304s.

Changed the resource hash seed and saw 200s, then 304s on reload.

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: bmaurer, aran, tuomaspelkonen
Differential Revision: 253

Details

Committed
epriestley <git@epriestley.com>May 10 2011, 23:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe32fd1a871c3: Correctly focus elements in Workflow dialogs
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHe27c5f26e545: Allow Celerity to return "304 Not Modified" responses (authored by epriestley <git@epriestley.com>).May 10 2011, 23:33