Homec4science

Improve Diffusion browse performance for large files

Authored by epriestley <git@epriestley.com> on Jan 6 2016, 15:41.

Description

Improve Diffusion browse performance for large files

Summary:
When looking at a large file in Diffusion:

  • disable highlighting if it's huge and show a note about why;
  • pick up a few other optimizations.

Test Plan: Locally, this improves the main render of __phutil_library_map__.php from 3,200ms to 600ms for me, at the cost of syntax highlighting (we can eventually add view options and let users re-enable it).

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14959

Details

Committed
epriestley <git@epriestley.com>Jan 6 2016, 18:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9728c65e9358: Drive blame generation through `diffusion.blame`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH91a01e57039e: Improve Diffusion browse performance for large files (authored by epriestley <git@epriestley.com>).Jan 6 2016, 18:24