Homec4science

Add options to include patches inline or attached for Diffusion commit emails

Authored by epriestley <git@epriestley.com> on Jul 12 2012, 22:33.

Description

Add options to include patches inline or attached for Diffusion commit emails

Summary:
See D818 for an older attempt at this. Support code has matured to the point where the patch is pretty straightforward.

@tido, this was a long-standing request from Aditya back in the day.

Test Plan: Used reparse.php --herald to send myself a bunch of emails with various patch configurations. Confirmed that limits are respected, reasonable errors arise when they're violated, etc. (Timeout is a little funky but that's out of scope here, I think.)

Reviewers: btrahan

Reviewed By: btrahan

CC: tido, aran

Maniphest Tasks: T456

Differential Revision: https://secure.phabricator.com/D2967

Details

Committed
epriestley <git@epriestley.com>Jul 12 2012, 22:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2b690372dedc: Fix several issues with Differential exception email
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9574b91e55d4: Add options to include patches inline or attached for Diffusion commit emails (authored by epriestley <git@epriestley.com>).Jul 12 2012, 22:33