Homec4science

Prevent delivery of email to disabled objects

Authored by epriestley <git@epriestley.com> on Nov 16 2011, 18:49.

Description

Prevent delivery of email to disabled objects

Summary: See T625. Facebook's REST-based MTA layer had a check for this so I
overlooked it in porting it out. We should not attempt to deliver email to
disabled users.

Test Plan:
Used MetaMTA console to send email to:

  • No users: received "no To" exception.
  • A disabled user: received "all To disabled" exception.
  • A valid user: received email.
  • A valid user and a disabled user: received email to valid user only.

(Note that you can't easily send to disabled users directly since they don't
appear in the typeahead, but you can prefill it and then disable the user by
hitting "Send".)

Reviewers: btrahan, jungejason, nh, tuomaspelkonen, aran

Reviewed By: aran

CC: skrul, aran, epriestley

Differential Revision: 1120

Details

Committed
epriestley <git@epriestley.com>Nov 16 2011, 20:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHef020f711ef7: Ensure Maniphest CC PHID list is always a list in maniphest.info
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH98c8e150b074: Prevent delivery of email to disabled objects (authored by epriestley <git@epriestley.com>).Nov 16 2011, 20:07