Homec4science

Unhighlight lines modified in rebase

Authored by vrana <jakubv@fb.com> on Jun 15 2012, 09:53.

Description

Unhighlight lines modified in rebase

Summary:
Diff of diffs display changes between new versions of file.
This is bad after rebase because there can be many unrelated changes so it is hard to spot the real change.

This diff unhighlights the lines that were added or removed in rebase.
The changes are still visible (they can be sometimes relevant) but very subtle.

Test Plan:

  1. Add, change and delete line. Display diff.
  2. Add and change some lines in parent. Rebase. Display diff. Display diff of diff.
  3. Change and add some lines. Display diff. Display diff to first diff. Display diff to second diff.

Reviewers: epriestley, jungejason

Reviewed By: jungejason

CC: jungejason, aran, Korvin

Differential Revision: https://secure.phabricator.com/D2761

Details

Committed
vrana <jakubv@fb.com>Jun 30 2012, 02:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd70f8dad3f37: Change lock in PullLocalDaemon to only lock on discovery
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH99df72b81cb3: Unhighlight lines modified in rebase (authored by vrana <jakubv@fb.com>).Jun 30 2012, 02:21