Homec4science

Make race condition window for Conpherence smaller and rarer

Authored by epriestley <git@epriestley.com> on Jan 8 2015, 18:44.

Description

Make race condition window for Conpherence smaller and rarer

Summary:
Ref T6713. This isn't very clean, and primarily unblocks D11143.

After D11143, I have a reliable local race where I submit, get a notification immediately, then get a double update (form submission + notification-triggered update).

Instead, make the notification updates wait for form submissions.

This doesn't resolve the race completely. The notification updates don't block chat submission (only the other way around), so if you're really fast you can submit at the same time someone else sends chat and race. But this fixes the most glaring issue.

The overall structure here is still pretty shaky but I tried to improve things a little, at least.

Test Plan: Chatted with myself, saw 0 races instead of 100% races.

Reviewers: btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T6713

Differential Revision: https://secure.phabricator.com/D11277

Details

Committed
epriestley <git@epriestley.com>Jan 8 2015, 18:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH6a7469e1aaee: Don't show notifications about your own actions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9a8eb4026e42: Make race condition window for Conpherence smaller and rarer (authored by epriestley <git@epriestley.com>).Jan 8 2015, 18:44