Homec4science

Modernize Diffusion `commitparentsquery`

Authored by epriestley <git@epriestley.com> on Dec 20 2013, 21:39.

Description

Modernize Diffusion commitparentsquery

Summary: Ref T4195. Ref T2783. We have an old-school implementation of this; move it into a LowLevel query and make callers all run through Conduit. I need the LowLevel query for hooks, to implement an "is merge commit" Herald rule.

Test Plan:

  • Ran query via Conduit for SVN, Mercurial, Git.
  • Parsed a commit which closed a revision, attach/closed worked correctly.
  • Browsed Diffusion.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4195, T2783

Differential Revision: https://secure.phabricator.com/D7808

Details

Committed
epriestley <git@epriestley.com>Dec 20 2013, 21:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH72c73d644b0e: Add an "Accepted Differential revision" field to Commit and pre-commit Content…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9c938701c3dd: Modernize Diffusion `commitparentsquery` (authored by epriestley <git@epriestley.com>).Dec 20 2013, 21:39