Homec4science

upgrade diffusion to use modern header UI and fix a few quirks

Authored by Bob Trahan <bob.trahan@gmail.com> on Dec 13 2012, 02:50.

Description

upgrade diffusion to use modern header UI and fix a few quirks

Summary:
upgrades are CrumbsView, HeaderView, PropertyListView, and ActionListView. I had to modify CrumbsView stuff a bit to handle the "advanced" diffusion crumbs.

Quirks fixed include making file tree view show up in diffusion, the page not have extra space when the file tree is hidden, links no longer breaking once you visit files (since without the change the files always got "/" appended and thus 404'd), and a differential quirk where it read "next step:" and that colon is a no no,

Test Plan: played around in diffusion and differential

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, chad

Maniphest Tasks: T2048, T2178

Differential Revision: https://secure.phabricator.com/D4169

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Dec 13 2012, 02:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH239eca13d753: Fix fatal in Maniphest when viewing "show details" of a task description edit
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH9e8387175e2e: upgrade diffusion to use modern header UI and fix a few quirks (authored by Bob Trahan <bob.trahan@gmail.com>).Dec 13 2012, 02:50