Homec4science

Add "raw author name" and "raw committer name" as Herald fields for commit…

Authored by epriestley <git@epriestley.com> on Dec 27 2013, 22:16.

Description

Add "raw author name" and "raw committer name" as Herald fields for commit content hooks

Summary:
Ref T4195. A legitimate rule which needs this field is "do not allow commits as root". Interestingly, we have exactly one commit as root in each Phabricator, Arcanist and libphutil.

Since the committer and author don't need to be Phabricator accounts (just the Pusher), the existing "Committer" and "Author" fields can't express this rule (they'll be empty).

Test Plan: {F93406}

Reviewers: btrahan

Reviewed By: btrahan

CC: SEJeff, aran

Maniphest Tasks: T4195

Differential Revision: https://secure.phabricator.com/D7841

Details

Committed
epriestley <git@epriestley.com>Dec 27 2013, 22:16
Pushed
aubortJan 31 2017, 17:16
Parents
rPHce78bf1de4e5: Make all bin/* scripts locate their workflows dynamically
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH9f38aaa5dec4: Add "raw author name" and "raw committer name" as Herald fields for commit… (authored by epriestley <git@epriestley.com>).Dec 27 2013, 22:16