Improve test data format for XHPAST unit tests
12167cf6fb23
Actions

Authored by Joshua Spence <josh@freelancer.com> on Nov 18 2015, 21:14.

Description

Improve test data format for XHPAST unit tests

Summary: Instead of having the input data and expected output stored in separate files, combine all data into a single file format similar to the *.lint-test format.

Test Plan: Ran unit tests.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14500

Details

Committed

Joshua Spence <josh@freelancer.com>

Nov 18 2015, 21:14

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU67f26422b91a: Use setters instead of public properties

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rPHU12167cf6fb23: Improve test data format for XHPAST unit tests (authored by Joshua Spence <josh@freelancer.com>).Nov 18 2015, 21:14

Changes (46)

				Path
	M			src/parser/xhpast/__tests__/PHPASTParserTestCase.php
	D			src/parser/xhpast/__tests__/data/base-fail-parse.php.expect
	M			src/parser/xhpast/__tests__/data/base-fail-parse.php.test
	M			src/parser/xhpast/__tests__/data/base-fail-syntax.php.test
	D			src/parser/xhpast/__tests__/data/base-pass.php.expect
	M			src/parser/xhpast/__tests__/data/base-pass.php.test
	V			src/parser/xhpast/__tests__/data/{namespace.php.expect → namespace.php.test}
	V			src/parser/xhpast/__tests__/data/{namespace.php.test ← namespace.php.expect}
	M			src/parser/xhpast/__tests__/data/php-access-on-instanciation-invalid.test
	V			src/parser/xhpast/__tests__/data/{php-access-on-instanciation.expect → php-access-on-instanciation.test}
	V			src/parser/xhpast/__tests__/data/{php-access-on-instanciation.test ← php-access-on-instanciation.expect}
	V			src/parser/xhpast/__tests__/data/{php-array-dereference-2.expect → php-array-dereference-2.test}
	V			src/parser/xhpast/__tests__/data/{php-array-dereference-2.test ← php-array-dereference-2.expect}
	V			src/parser/xhpast/__tests__/data/{php-array-dereference-3.expect → php-array-dereference-3.test}
	V			src/parser/xhpast/__tests__/data/{php-array-dereference-3.test ← php-array-dereference-3.expect}
	V			src/parser/xhpast/__tests__/data/{php-array-dereference.expect → php-array-dereference.test}
	V			src/parser/xhpast/__tests__/data/{php-array-dereference.test ← php-array-dereference.expect}
	V			src/parser/xhpast/__tests__/data/{php-binary-literal.php.expect → php-binary-literal.php.test}
	V			src/parser/xhpast/__tests__/data/{php-binary-literal.php.test ← php-binary-literal.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-callable-typehint.php.expect → php-callable-typehint.php.test}
	V			src/parser/xhpast/__tests__/data/{php-callable-typehint.php.test ← php-callable-typehint.php.expect}
	M			src/parser/xhpast/__tests__/data/php-class-expr.php.test
	V			src/parser/xhpast/__tests__/data/{php-comments.php.expect → php-comments.php.test}
	V			src/parser/xhpast/__tests__/data/{php-comments.php.test ← php-comments.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-empty-heredoc.php.expect → php-empty-heredoc.php.test}
	V			src/parser/xhpast/__tests__/data/{php-empty-heredoc.php.test ← php-empty-heredoc.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-finally.php.expect → php-finally.php.test}
	V			src/parser/xhpast/__tests__/data/{php-finally.php.test ← php-finally.php.expect}
	M			src/parser/xhpast/__tests__/data/php-foreach-list.php.test
	V			src/parser/xhpast/__tests__/data/{php-heredoc-terminal.php.expect → php-heredoc-terminal.php.test}
	V			src/parser/xhpast/__tests__/data/{php-heredoc-terminal.php.test ← php-heredoc-terminal.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-literal-index.php.expect → php-literal-index.php.test}
	V			src/parser/xhpast/__tests__/data/{php-literal-index.php.test ← php-literal-index.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-literals.php.expect → php-literals.php.test}
	V			src/parser/xhpast/__tests__/data/{php-literals.php.test ← php-literals.php.expect}
	M			src/parser/xhpast/__tests__/data/php-nested-quotes.test
	V			src/parser/xhpast/__tests__/data/{php-short-array.php.expect → php-short-array.php.test}
	V			src/parser/xhpast/__tests__/data/{php-short-array.php.test ← php-short-array.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-syntax.php.expect → php-syntax.php.test}
	V			src/parser/xhpast/__tests__/data/{php-syntax.php.test ← php-syntax.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-tags.php.expect → php-tags.php.test}
	V			src/parser/xhpast/__tests__/data/{php-tags.php.test ← php-tags.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-traits.php.expect → php-traits.php.test}
	V			src/parser/xhpast/__tests__/data/{php-traits.php.test ← php-traits.php.expect}
	V			src/parser/xhpast/__tests__/data/{php-yield.php.expect → php-yield.php.test}
	V			src/parser/xhpast/__tests__/data/{php-yield.php.test ← php-yield.php.expect}