Homec4science

Enable console "log" channel when processing --trace in daemons

Authored by epriestley <git@epriestley.com> on Jan 17 2013, 19:48.

Description

Enable console "log" channel when processing --trace in daemons

Summary:
Normally, --trace is handled by PhutilArgumentParser, which enables the log channel. For daemons, --trace is handled specially, and currently does not enable the log channel, so --trace only activates verbose messages, not queries and command execution. Specifically, queries and commands are not currently visible under phd debug.

(Probably we should implement standard --trace here, but the daemons need some magic around it and this is a simpler fix for the moment.)

Test Plan: Ran phd debug pulllocal, saw command execution.

Reviewers: brennantaylor, btrahan, vrana

Reviewed By: brennantaylor

CC: aran

Differential Revision: https://secure.phabricator.com/D4486

Details

Committed
epriestley <git@epriestley.com>Jan 17 2013, 19:48
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU779f1f195cef: Allow asserting instances of array
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU27e9eb89e490: Enable console "log" channel when processing --trace in daemons (authored by epriestley <git@epriestley.com>).Jan 17 2013, 19:48