Add an `XHPAST::getNamespace()` method
44113cfd0db1
Actions

Authored by Joshua Spence <josh@freelancer.com> on Nov 19 2015, 20:40.

Description

Add an XHPAST::getNamespace() method

Summary: This throws away D14498 and starts again. Basically, the grammar of PHP does not allow namespace statements to be parsed consistently (see some discussion in D14506). Instead of complicating the grammar, move the logic of determining a node's namespace to the PHP representation of the AST.

Test Plan: Added unit tests.

Reviewers: richardvanvelzen, #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D14512

Details

Committed

Joshua Spence <josh@freelancer.com>

Nov 19 2015, 20:47

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU12167cf6fb23: Improve test data format for XHPAST unit tests

Branches

Unknown

Tags

Unknown

Event Timeline

Joshua Spence <josh@freelancer.com> committed rPHU44113cfd0db1: Add an `XHPAST::getNamespace()` method (authored by Joshua Spence <josh@freelancer.com>).Nov 19 2015, 20:47

Changes (13)

		Path
M		src/parser/aast/api/AASTNode.php
M		src/parser/xhpast/__tests__/data/namespace.php.test
M		src/parser/xhpast/api/XHPASTNode.php
M		src/parser/xhpast/api/__tests__/XHPASTNodeTestCase.php
A	(dir)	src/parser/xhpast/api/__tests__/namespace/
A		src/parser/xhpast/api/__tests__/namespace/braces.lint-test
A		src/parser/xhpast/api/__tests__/namespace/mixed.php.test
A		src/parser/xhpast/api/__tests__/namespace/namespace.lint-test
A		src/parser/xhpast/api/__tests__/namespace/no-namespace.lint-test
M		src/parser/xhpast/bin/PhutilXHPASTBinary.php
M		support/xhpast/parser.y
M		support/xhpast/parser.yacc.cpp
M		support/xhpast/xhpast.cpp