Add coalesce and spaceship operators to xhpast
4b75e0c34e52
Actions

Authored by Richard van Velzen <rvanvelzen@experty.com> on May 4 2016, 11:02.

Description

Add coalesce and spaceship operators to xhpast

Summary:

$value ?? $other is roughtly translates to isset($value) ? $value : $other
$a <=> $b translates to ($a < $b) ? -1 : (($a > $b) ? 1 : 0).

Because these new tokens appear in-between other tokens, a lot of token values were updated. All test cases have been updated to have the correct token values.

Test Plan: Fully rebuild xhpast, run all parser tests.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15860

Details

Committed

Richard van Velzen <rvanvelzen@experty.com>

May 19 2016, 10:59

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUb25e0477b280: Allow "+" to remain unescaped by csprintf('%R', ...)

Branches

Unknown

Tags

Unknown

Event Timeline

Richard van Velzen <rvanvelzen@experty.com> committed rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast (authored by Richard van Velzen <rvanvelzen@experty.com>).May 19 2016, 10:59

Changes (35)

				Path
	M			src/parser/xhpast/__tests__/data/base-pass.php.test
	M			src/parser/xhpast/__tests__/data/call-time-pass-by-ref.php.test
	M			src/parser/xhpast/__tests__/data/namespace.php.test
	P			src/parser/xhpast/__tests__/data/operator-coalesce.php.test Copied from src/parser/xhpast/__tests__/data/php-only-finally.test
	A			src/parser/xhpast/__tests__/data/operator-spaceship-nonassoc.php.test
	P			src/parser/xhpast/__tests__/data/operator-spaceship.php.test Copied from src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test
	M			src/parser/xhpast/__tests__/data/php-access-on-instanciation.test
	M			src/parser/xhpast/__tests__/data/php-array-dereference-2.test
	M			src/parser/xhpast/__tests__/data/php-array-dereference-3.test
	M			src/parser/xhpast/__tests__/data/php-array-dereference.test
	M			src/parser/xhpast/__tests__/data/php-binary-literal.php.test
	M			src/parser/xhpast/__tests__/data/php-callable-typehint.php.test
	M			src/parser/xhpast/__tests__/data/php-comments.php.test
	P			src/parser/xhpast/__tests__/data/php-empty-heredoc.php.test Copied to src/parser/xhpast/__tests__/data/operator-spaceship.php.test
	M			src/parser/xhpast/__tests__/data/php-finally.php.test
	M			src/parser/xhpast/__tests__/data/php-literal-index.php.test
	M			src/parser/xhpast/__tests__/data/php-literals.php.test
	P			src/parser/xhpast/__tests__/data/php-only-finally.test Copied to src/parser/xhpast/__tests__/data/operator-coalesce.php.test
	M			src/parser/xhpast/__tests__/data/php-short-array.php.test
	M			src/parser/xhpast/__tests__/data/php-syntax.php.test
	M			src/parser/xhpast/__tests__/data/php-tags.php.test
	M			src/parser/xhpast/__tests__/data/php-traits.php.test
	M			src/parser/xhpast/__tests__/data/php-yield.php.test
	M			src/parser/xhpast/__tests__/data/return-type.php.test
	M			src/parser/xhpast/__tests__/data/use.php.test
	M			src/parser/xhpast/__tests__/data/variadic.php.test
	M			src/parser/xhpast/bin/PhutilXHPASTBinary.php
	M			src/parser/xhpast/parser_tokens.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser.yacc.cpp
	M			support/xhpast/parser.yacc.hpp
	M			support/xhpast/scanner.l
	M			support/xhpast/scanner.lex.cpp
	M			support/xhpast/scanner.lex.hpp
	M			support/xhpast/xhpast.cpp