Homec4science

Censor credentials with "********" instead of "xxxxx"

Authored by epriestley <git@epriestley.com> on Jun 27 2016, 16:51.

Description

Censor credentials with "****" instead of "xxxxx"

Summary: Ref T10982. There, and in other cases, it isn't obvious to users that we're censoring credentials when they see censored commands. Try using "****" instead of "xxxxx" to hopefully make it more clear.

Test Plan:

  • Ran unit tests.
  • Ran repository pull --trace, saw this output:
>>> [20] <exec> $ git clone --bare -- '********' '/Users/epriestley/dev/core/repo/local/55'
<<< [20] <exec> 3,998,331 us

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10982

Differential Revision: https://secure.phabricator.com/D16181

Details

Committed
epriestley <git@epriestley.com>Jun 27 2016, 17:22
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU51c179b4c000: Support class const dereferencing in xhpast
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU5796beffff16: Censor credentials with "********" instead of "xxxxx" (authored by epriestley <git@epriestley.com>).Jun 27 2016, 17:22