Homec4science

Improve error messages from Filesystem::readRandomBytes()

Authored by epriestley <git@epriestley.com> on Nov 25 2013, 23:56.

Description

Improve error messages from Filesystem::readRandomBytes()

Summary: Fixes T4153. Primarily, raise a better error message on Windows. Also make the function a little stricter and a little better tested.

Test Plan: Unit tests.

Reviewers: btrahan, hach-que

Reviewed By: hach-que

CC: aran

Maniphest Tasks: T4153

Differential Revision: https://secure.phabricator.com/D7650

Details

Committed
epriestley <git@epriestley.com>Nov 25 2013, 23:56
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU8c4c27f41bf6: Improve performacne of PhutilSymbolLoader
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU5fab43a1cccd: Improve error messages from Filesystem::readRandomBytes() (authored by epriestley <git@epriestley.com>).Nov 25 2013, 23:56