Homec4science

Improve the performance of phutil_loggable_string()

Authored by epriestley <git@epriestley.com> on Nov 26 2013, 17:58.

Description

Improve the performance of phutil_loggable_string()

Summary:
Ref T4162.

  • Before doing anything character oriented, test if the whole string is fine to print as-is.
  • Reduce the number of calls to string().

Test Plan: Saw cost drop on profiles.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4162

Differential Revision: https://secure.phabricator.com/D7656

Details

Committed
epriestley <git@epriestley.com>Nov 26 2013, 17:58
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU5fab43a1cccd: Improve error messages from Filesystem::readRandomBytes()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU6d5ec28d2e49: Improve the performance of phutil_loggable_string() (authored by epriestley <git@epriestley.com>).Nov 26 2013, 17:58