Homec4science

Make XHPAST keep unterminated mutiline comments instead of discarding them

Authored by epriestley <git@epriestley.com> on Jan 31 2012, 21:06.

Description

Make XHPAST keep unterminated mutiline comments instead of discarding them

Summary: We don't currently emit a token when we hit EOF if in the comment or
doc comment state. In these states, emit a token on EOF.

Test Plan: Ran XHPAST against inputs like '<?php /* x' and '<?php /** x'.

Reviewers: nh, btrahan, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T812

Differential Revision: https://secure.phabricator.com/D1530

Details

Committed
epriestley <git@epriestley.com>Jan 31 2012, 21:06
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU97102d64c0cd: Mark all final-izable classes in libphutil as 'final'
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU6f71ac6b9432: Make XHPAST keep unterminated mutiline comments instead of discarding them (authored by epriestley <git@epriestley.com>).Jan 31 2012, 21:06