Mark all final-izable classes in libphutil as 'final'
97102d64c0cd
Actions

Authored by epriestley <git@epriestley.com> on Jan 30 2012, 01:32.

Description

Mark all final-izable classes in libphutil as 'final'

Summary: Resolves all "not abstract or final" lint warnings in libphutil by
"final"-izing anything that isn't explicitly extensible.

Test Plan: Ran lint; no class errors. Ran testEverythingImplemented in
phabricator.

Reviewers: btrahan, aran, jungejason

Reviewed By: btrahan

CC: aran, epriestley

Maniphest Tasks: T795

Differential Revision: https://secure.phabricator.com/D1512

Details

Committed

epriestley <git@epriestley.com>

Jan 30 2012, 01:32

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUc6a91d0480d6: Remove XHP and yield support from XHPAST

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU97102d64c0cd: Mark all final-izable classes in libphutil as 'final' (authored by epriestley <git@epriestley.com>).Jan 30 2012, 01:32

Changes (64)

				Path
	M			src/__phutil_library_init__.php
	M			src/conduit/client/ConduitClient.php
	M			src/conduit/client/ConduitClientException.php
	M			src/conduit/client/ConduitFuture.php
	M			src/console/PhutilConsoleFormatter.php
	M			src/daemon/overseer/PhutilDaemonOverseer.php
	M			src/daemon/torture/excessiveservicecalls/PhutilExcessiveServiceCallsDaemon.php
	M			src/daemon/torture/fatal/PhutilFatalDaemon.php
	M			src/daemon/torture/hangforever/PhutilHangForeverDaemon.php
	M			src/daemon/torture/nice/PhutilNiceDaemon.php
	M			src/daemon/torture/processgroup/PhutilProcessGroupDaemon.php
	M			src/daemon/torture/saturatestdout/PhutilSaturateStdoutDaemon.php
	M			src/events/constant/type/PhutilEventType.php
	M			src/events/engine/PhutilEventEngine.php
	M			src/events/event/PhutilEvent.php
	M			src/filesystem/Filesystem.php
	M			src/filesystem/FilesystemException.php
	M			src/filesystem/tempfile/TempFile.php
	M			src/future/FutureIterator.php
	M			src/future/exec/CommandException.php
	M			src/future/exec/ExecFuture.php
	M			src/future/http/https/HTTPSFuture.php
	M			src/future/immediate/ImmediateFuture.php
	M			src/markup/__tests__/PhutilMarkupTestCase.php
	M			src/markup/engine/remarkup/__tests__/PhutilRemarkupEngineTestCase.php
	M			src/markup/engine/remarkup/blockrule/remarkupcode/PhutilRemarkupEngineRemarkupCodeBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkupdefault/PhutilRemarkupEngineRemarkupDefaultBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkupheader/PhutilRemarkupEngineRemarkupHeaderBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkupinline/PhutilRemarkupEngineRemarkupInlineBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkuplist/PhutilRemarkupEngineRemarkupListBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkupliteral/PhutilRemarkupEngineRemarkupLiteralBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkupnote/PhutilRemarkupEngineRemarkupNoteBlockRule.php
	M			src/markup/engine/remarkup/blockrule/remarkupquotes/PhutilRemarkupEngineRemarkupQuotesBlockRule.php
	M			src/markup/engine/remarkup/markuprule/bold/PhutilRemarkupRuleBold.php
	M			src/markup/engine/remarkup/markuprule/escapehtml/PhutilRemarkupRuleEscapeHTML.php
	M			src/markup/engine/remarkup/markuprule/escaperemarkup/PhutilRemarkupRuleEscapeRemarkup.php
	M			src/markup/engine/remarkup/markuprule/hyperlink/PhutilRemarkupRuleHyperlink.php
	M			src/markup/engine/remarkup/markuprule/italics/PhutilRemarkupRuleItalic.php
	M			src/markup/engine/remarkup/markuprule/linebreaks/PhutilRemarkupRuleLinebreaks.php
	M			src/markup/engine/remarkup/markuprule/monospace/PhutilRemarkupRuleMonospace.php
	M			src/markup/syntax/engine/default/PhutilDefaultSyntaxHighlighterEngine.php
	M			src/markup/syntax/engine/default/__tests__/PhutilDefaultSyntaxHighlighterEngineTestCase.php
	M			src/markup/syntax/highlighter/default/PhutilDefaultSyntaxHighlighter.php
	M			src/markup/syntax/highlighter/diviner/PhutilDivinerSyntaxHighlighter.php
	M			src/markup/syntax/highlighter/pygments/PhutilPygmentsSyntaxHighlighter.php
	M			src/markup/syntax/highlighter/pygments/future/PhutilDefaultSyntaxHighlighterEnginePygmentsFuture.php
	M			src/markup/syntax/highlighter/rainbow/PhutilRainbowSyntaxHighlighter.php
	M			src/markup/syntax/highlighter/xhpast/PhutilXHPASTSyntaxHighlighter.php
	M			src/parser/aast/api/list/AASTNodeList.php
	M			src/parser/docblock/PhutilDocblockParser.php
	M			src/parser/docblock/__tests__/PhutilDocblockParserTestCase.php
	M			src/parser/json/__tests__/PhutilJSONTestCase.php
	M			src/parser/xhpast/api/exception/XHPASTSyntaxErrorException.php
	M			src/parser/xhpast/api/node/XHPASTNode.php
	M			src/parser/xhpast/api/token/XHPASTToken.php
	M			src/parser/xhpast/api/tree/XHPASTTree.php
	M			src/parser/xhpast/api/tree/__tests__/XHPASTTreeTestCase.php
	M			src/readableserializer/PhutilReadableSerializer.php
	M			src/symbols/exception/missing/PhutilMissingSymbolException.php
	M			src/utils/__tests__/MFilterTestHelper.php
	M			src/utils/__tests__/PhutilUTF8TestCase.php
	M			src/utils/__tests__/PhutilUtilsTestCase.php
	M			src/utils/abstractgraph/__tests__/AbstractDirectedGraphTestCase.php
	M			src/utils/abstractgraph/__tests__/TestAbstractDirectedGraph.php