XHPAST array_function_derefence support
8fb705f8e4b9
Actions

Authored by Eric Stern <eric@ericstern.com> on Feb 7 2014, 19:30.

Description

XHPAST array_function_derefence support

Summary: Ref. T4334. Makes "isset(foo()[1])" syntax work, which was added in 5.4

Test Plan:
arc unit
Added test case for known-good syntax, TDD'd the grammar file until it worked (mostly scraped from Zend)
generate_php_symbols.php of WePay's entire codebase with updated XHPAST, no errors at all.

Reviewers: epriestley, btrahan, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D8154

Details

Committed

epriestley <git@epriestley.com>

Feb 7 2014, 19:30

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHU9e85344d3ffb: Encode username and password correctly in PhutilURI

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU8fb705f8e4b9: XHPAST array_function_derefence support (authored by Eric Stern <eric@ericstern.com>).Feb 7 2014, 19:30

Changes (6)

				Path
	P			src/parser/xhpast/__tests__/data/php-array-dereference.expect Copied from src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect
	A			src/parser/xhpast/__tests__/data/php-array-dereference.test
	M			src/parser/xhpast/bin/xhpast_parse.php
	M			support/xhpast/parser.y
	M			support/xhpast/parser.yacc.cpp
	M			support/xhpast/xhpast.cpp