Homec4science

Encode username and password correctly in PhutilURI

Authored by epriestley <git@epriestley.com> on Feb 6 2014, 09:41.

Description

Encode username and password correctly in PhutilURI

Summary: Fixes T4374. We do not encode passwords in URIs correctly, so passwords with, e.g., the @ character do not work correctly.

Test Plan: Added unit tests.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4374

Differential Revision: https://secure.phabricator.com/D8144

Details

Committed
epriestley <git@epriestley.com>Feb 6 2014, 09:41
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUe719f331aa1a: Add support in XHPAST for "(new X)->y" syntax (added in 5.4)
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHU9e85344d3ffb: Encode username and password correctly in PhutilURI (authored by epriestley <git@epriestley.com>).Feb 6 2014, 09:41