Homec4science

Allow PhutilDeferredLog to fail more quietly

Authored by epriestley <git@epriestley.com> on May 10 2013, 01:07.

Description

Allow PhutilDeferredLog to fail more quietly

Summary:
We've hit a couple of issues with the exception PhutilDeferredLog throws when used in the Phabricator access log. In particular, it is thrown at an awkward time, when the request is already complete. It is also thrown from an awkward place in the stack, where we've already unwound everything and are calling __destruct(). It also isn't especially important.

Allow it to be degraded into a log message instead. The next diff will apply this degradation in Phabricator.

Test Plan: Unit tests; see next revision.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3144

Differential Revision: https://secure.phabricator.com/D5874

Details

Committed
epriestley <git@epriestley.com>May 10 2013, 01:07
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUb03bdc33a4a1: Parse most `[name](href)` Markdown-style links in Remarkup
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUa63fb15861b9: Allow PhutilDeferredLog to fail more quietly (authored by epriestley <git@epriestley.com>).May 10 2013, 01:07