Homec4science

Don't detect long sentences which happen to have a colon in them as Git URIs

Authored by epriestley <git@epriestley.com> on Jun 13 2016, 18:29.

Description

Don't detect long sentences which happen to have a colon in them as Git URIs

Summary:
Some very liberal code is currently trying to parse commit summaries aggressively as Git URIs, and leading to this:

Failed to parse URI "Summary: Ref T11137. This addresses three general issues:" as a Git URI.

Currently visible here:

https://secure.phabricator.com/rPHU8bb124c37de3dfa29fcd23d4be53a5696b705c81

Don't detect these as Git URIs.

Test Plan: Unit tests.

Reviewers: chad

Reviewed By: chad

Subscribers: 20after4

Maniphest Tasks: T11137

Differential Revision: https://secure.phabricator.com/D16103

Details

Committed
epriestley <git@epriestley.com>Jun 13 2016, 19:25
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU8bb124c37de3: Merge PhutilGitURI into PhutilURI
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUa815d2d850b8: Don't detect long sentences which happen to have a colon in them as Git URIs (authored by epriestley <git@epriestley.com>).Jun 13 2016, 19:25