Homec4science

Don't apply inline rules in Literal remarkup blocks

Authored by epriestley <git@epriestley.com> on Jul 10 2013, 01:22.

Description

Don't apply inline rules in Literal remarkup blocks

Summary:

  • Long ago, we applied HTML escaping in literal block rules (%%% .. %%%) by using an HTML inline rule.
    • We no longer need to do this, so literal blocks don't need to apply inline rules at all.
  • I think I imagined that certain block rules might want nonstandard inline rules when building Remarkup originally.
    • They never do and we don't have any use cases on the horizon where they might.

This allows us to simplify remarkup code in Phabricator.

Test Plan: Typed %%% <strong>!!</strong> %%% into Remarkup and made sure it was still escaped properly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6395

Details

Committed
epriestley <git@epriestley.com>Jul 10 2013, 01:22
Pushed
aubortMar 17 2017, 12:03
Parents
rPHUee395349eb8d: Add service call profiling to LDAP
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUaae486ea0f4e: Don't apply inline rules in Literal remarkup blocks (authored by epriestley <git@epriestley.com>).Jul 10 2013, 01:22