Homec4science

Add service call profiling to LDAP

Authored by epriestley <git@epriestley.com> on Jul 10 2013, 01:22.

Description

Add service call profiling to LDAP

Summary: We don't pick up LDAP calls in the service profiler, but should. Replaces some slightly more detailed but nonstandard and invasive debugging code, since LDAP seems stable now.

Test Plan:

$ ~/src/php-src/sapi/cli/php -f ./bin/auth ldap --trace
>>> [2] <connect> phabricator2_auth
<<< [2] <connect> 1,755 us
>>> [3] <query> SELECT * FROM `auth_providerconfig`  ORDER BY id DESC
<<< [3] <query> 423 us
Enter LDAP Credentials

    LDAP Username:  ldapuser
>>> [4] <exec> $ stty -echo
<<< [4] <exec> 10,370 us

    LDAP Password:  >>> [5] <exec> $ stty echo
<<< [5] <exec> 6,844 us

Connecting to LDAP...
>>> [6] <ldap> connect (127.0.0.1:389)
<<< [6] <ldap> 12,932 us
>>> [7] <ldap> bind (sn=ldapuser,ou=People, dc=aphront, dc=com)
<<< [7] <ldap> 6,860 us
>>> [8] <ldap> search (ou=People, dc=aphront, dc=com, sn=ldapuser)
<<< [8] <ldap> 5,907 us
Found LDAP Account: ldapuser

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D6391

Details

Committed
epriestley <git@epriestley.com>Jul 10 2013, 01:22
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU505b89b2b9c2: Add test coverage for PhutilErrorHandler and silence operator ("@")
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUee395349eb8d: Add service call profiling to LDAP (authored by epriestley <git@epriestley.com>).Jul 10 2013, 01:22