Homec4science

Make setCWD() with bad paths safer

Authored by epriestley <git@epriestley.com> on Apr 22 2016, 14:23.

Description

Make setCWD() with bad paths safer

Summary: Ref T10853. This isn't a complete fix, but should prevent the most serious mistakes with setCWD() on bad paths.

Test Plan:

  • Wrote a script using setCWD().
  • Gave it a bad path: got an explicit error.
  • Gave it a good path: things worked great.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10853

Differential Revision: https://secure.phabricator.com/D15785

Details

Committed
epriestley <git@epriestley.com>Apr 22 2016, 17:10
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU1341c014ca7c: Share Env/CWD methods between Passthru + ExecFuture, expose Env
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUb8058f6e29ba: Make setCWD() with bad paths safer (authored by epriestley <git@epriestley.com>).Apr 22 2016, 17:10