Homec4science

Correctly detect new version of xhpast build

Authored by Richard van Velzen <rvanvelzen@experty.com> on May 19 2016, 12:49.

Description

Correctly detect new version of xhpast build

Summary: When running lint after xhpast is updated, it tests whether the version is up-to-date. Because the version isn't reset before the test, it would think that the build failed, requiring a second run of lint

Test Plan: Downgraded xhpast, ran lint. Saw broken xhpast, but correct xhpast on second run. Applied patch, and got correct lint results regardless of version.

Reviewers: epriestley, #blessed_reviewers, chad

Reviewed By: epriestley, #blessed_reviewers, chad

Subscribers: Korvin, Firehed

Differential Revision: https://secure.phabricator.com/D15945

Details

Committed
Richard van Velzen <rvanvelzen@experty.com>May 19 2016, 16:07
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU4b75e0c34e52: Add coalesce and spaceship operators to xhpast
Branches
Unknown
Tags
Unknown

Event Timeline

Richard van Velzen <rvanvelzen@experty.com> committed rPHUbd56873ae4c0: Correctly detect new version of xhpast build (authored by Richard van Velzen <rvanvelzen@experty.com>).May 19 2016, 16:07