Homec4science

Disambiguate "host.com:123" as a port, not a relative path

Authored by epriestley <git@epriestley.com> on Jun 28 2016, 23:37.

Description

Disambiguate "host.com:123" as a port, not a relative path

Summary:
Ref T11222. When we parse "host.com:123", it could be a Git-style URI pointing at the file named "123" on the host. We currently interpret it as such.

Instead, always assume that completely numeric "paths" are port numbers.

Test Plan: Added failing test; made it pass.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11222

Differential Revision: https://secure.phabricator.com/D16187

Details

Committed
epriestley <git@epriestley.com>Jun 28 2016, 23:58
Pushed
aubortMar 17 2017, 12:03
Parents
rPHU5796beffff16: Censor credentials with "********" instead of "xxxxx"
Branches
Unknown
Tags
Unknown