Parse ICS datetimes and durations
f241706ade25
Actions

Authored by epriestley <git@epriestley.com> on Sep 13 2016, 20:38.

Description

Parse ICS datetimes and durations

Summary:
Ref T10747. This parses "SUMMARY" and "DESCRIPTION" from ICS (easy) and "DTSTART", "DTEND" and "DURATION" (big mess, as one might reasonably expect).

ICS dates can be absolute (e.g., at a specific time in history) or "floating". If an event is "floating", it has a date like "June 23 at 5PM", which is expected to be interpreted according to the viewer timezone, i.e. occur at different times in different timezones.

Dates can also be "start + end" or "start + duration". Worse, they can be a floating start plus a duration. Do a bunch of gymnastics to represent all this stuff faithfully.

This probably still doesn't handle all-day events properly, but I'll deal with them in the future.

Test Plan: Added unit tests; ran unit tests.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10747

Differential Revision: https://secure.phabricator.com/D16548

Details

Committed

epriestley <git@epriestley.com>

Sep 14 2016, 21:19

Pushed

aubort

Mar 17 2017, 12:03

Parents

rPHUf8af794b2135: Make error handling for ICS parsing more robust

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHUf241706ade25: Parse ICS datetimes and durations (authored by epriestley <git@epriestley.com>).Sep 14 2016, 21:19

Changes (20)

				Path
	M			src/__phutil_library_map__.php
	A			src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php
	A			src/parser/calendar/data/PhutilCalendarDateTime.php
	A			src/parser/calendar/data/PhutilCalendarDuration.php
	M			src/parser/calendar/data/PhutilCalendarEventNode.php
	A			src/parser/calendar/data/PhutilCalendarProxyDateTime.php
	A			src/parser/calendar/data/PhutilCalendarRelativeDateTime.php
	M			src/parser/calendar/ics/PhutilICSParser.php
	M			src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php
	A			src/parser/calendar/ics/__tests__/data/duration.ics
	P			src/parser/calendar/ics/__tests__/data/err-bad-datetime.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-double-quote.ics
	P			src/parser/calendar/ics/__tests__/data/err-bad-duration.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-double-quote.ics
	P			src/parser/calendar/ics/__tests__/data/err-bad-tzid.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-property.ics
	P			src/parser/calendar/ics/__tests__/data/err-empty-datetime.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-parameter.ics
	P			src/parser/calendar/ics/__tests__/data/err-empty-duration.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-parameter.ics
	P			src/parser/calendar/ics/__tests__/data/err-many-datetime.ics Copied from src/parser/calendar/ics/__tests__/data/err-missing-value.ics
	P			src/parser/calendar/ics/__tests__/data/err-many-duration.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-double-quote.ics
	P			src/parser/calendar/ics/__tests__/data/err-multiple-parameters.ics Copied from src/parser/calendar/ics/__tests__/data/err-malformed-property.ics
	A			src/parser/calendar/ics/__tests__/data/floating.ics
	M			src/parser/calendar/ics/__tests__/data/simple.ics

Parse ICS datetimes and durationsf241706ade25Actions

Description

Details

Event Timeline

Changes (20)

rPHUf241706ade25

src/__phutil_library_map__.php

src/parser/calendar/data/PhutilCalendarAbsoluteDateTime.php

src/parser/calendar/data/PhutilCalendarDateTime.php

src/parser/calendar/data/PhutilCalendarDuration.php

src/parser/calendar/data/PhutilCalendarEventNode.php

src/parser/calendar/data/PhutilCalendarProxyDateTime.php

src/parser/calendar/data/PhutilCalendarRelativeDateTime.php

src/parser/calendar/ics/PhutilICSParser.php

src/parser/calendar/ics/__tests__/PhutilICSParserTestCase.php

src/parser/calendar/ics/__tests__/data/duration.ics

src/parser/calendar/ics/__tests__/data/err-bad-datetime.ics

src/parser/calendar/ics/__tests__/data/err-bad-duration.ics

src/parser/calendar/ics/__tests__/data/err-bad-tzid.ics

src/parser/calendar/ics/__tests__/data/err-empty-datetime.ics

src/parser/calendar/ics/__tests__/data/err-empty-duration.ics

src/parser/calendar/ics/__tests__/data/err-many-datetime.ics

src/parser/calendar/ics/__tests__/data/err-many-duration.ics

src/parser/calendar/ics/__tests__/data/err-multiple-parameters.ics

src/parser/calendar/ics/__tests__/data/floating.ics

src/parser/calendar/ics/__tests__/data/simple.ics

Parse ICS datetimes and durations
f241706ade25
Actions

src/parser/calendar/ics/tests/PhutilICSParserTestCase.php

src/parser/calendar/ics/tests/data/duration.ics

src/parser/calendar/ics/tests/data/err-bad-datetime.ics

src/parser/calendar/ics/tests/data/err-bad-duration.ics

src/parser/calendar/ics/tests/data/err-bad-tzid.ics

src/parser/calendar/ics/tests/data/err-empty-datetime.ics

src/parser/calendar/ics/tests/data/err-empty-duration.ics

src/parser/calendar/ics/tests/data/err-many-datetime.ics

src/parser/calendar/ics/tests/data/err-many-duration.ics

src/parser/calendar/ics/tests/data/err-multiple-parameters.ics

src/parser/calendar/ics/tests/data/floating.ics

src/parser/calendar/ics/tests/data/simple.ics