Homec4science

Give projects a proper on-demand datasource

Authored by epriestley <git@epriestley.com> on Jul 18 2014, 01:35.

Description

Give projects a proper on-demand datasource

Summary:
Fixes T5614. Ref T4420. Other than the "users" datasource and a couple of others, many datasources ignore what the user typed and just return all results, then rely on the client to filter them.

This works fine for rarely used ("legalpad documents") or always small ("task priorities", "applications") datasets, but is something we should graudally move away from as datasets get larger.

Add a token table to projects, populate it, and use it to drive the datasource query. Additionally, expose it on the applicationsearch UI.

Test Plan:

  • Ran migration.
  • Manually checked the table.
  • Searched for projects by name from ApplicationSearch.
  • Searched for projects by name from typeahead.
  • Manually checked the typeahead response.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T5614, T4420

Differential Revision: https://secure.phabricator.com/D9896

Details

Committed
epriestley <git@epriestley.com>Jul 18 2014, 01:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf2fee5a84e62: Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa115810912e7: Give projects a proper on-demand datasource (authored by epriestley <git@epriestley.com>).Jul 18 2014, 01:35