Homec4science

Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the…

Authored by Joshua Spence <josh@joshuaspence.com> on Jul 18 2014, 01:20.

Description

Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the Aphlict server

Summary: Ref T5651. Only throw a HTTP 400 if the data is invalid (i.e. the request is bad). If something bad happens when trying to transmit the notification, throw a HTTP 500 instead.

Test Plan: Eye-ball it.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T5651

Differential Revision: https://secure.phabricator.com/D9968

Details

Committed
Joshua Spence <josh@joshuaspence.com>Jul 18 2014, 01:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH41a8837f78db: Make HTTP errors returned from the Aphlict server more specific
Branches
Unknown
Tags
Unknown

Event Timeline

Joshua Spence <josh@joshuaspence.com> committed rPHf2fee5a84e62: Return a HTTP 500 instead of a HTTP 400 if an internal error occurs in the… (authored by Joshua Spence <josh@joshuaspence.com>).Jul 18 2014, 01:20