Homec4science

Fix a fatal in Diviner when atoms extend ghosts

Authored by epriestley <git@epriestley.com> on Jun 15 2015, 22:52.

Description

Fix a fatal in Diviner when atoms extend ghosts

Summary:
Fixes T8547. I wasn't immediately able to reproduce this locally (although I didn't try too hard), but I think the issue is that when atoms extend ghosts (probably they are usually ghosts themselves?), we try to check the ghost language and fatal.

Instead, don't match ghosts when figuring out what an atom extends.

This could maybe be a little cleaner (match the ghosts, at lower priority, and show that they're ghosts?) but I'm not sure there's a real product use case for it, and this looks like a safer way to stop the bleeding for now.

Test Plan: Poked around Diviner locally.

Reviewers: joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T8547

Differential Revision: https://secure.phabricator.com/D13300

Details

Committed
epriestley <git@epriestley.com>Jun 15 2015, 22:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9f1235d87512: Fix a fatal in Calendar widget in Conpherence
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa1561a4d3a07: Fix a fatal in Diviner when atoms extend ghosts (authored by epriestley <git@epriestley.com>).Jun 15 2015, 22:52