Homec4science

Touch up PHP/JS interactions for inline comments

Authored by epriestley <git@epriestley.com> on Mar 28 2015, 01:08.

Description

Touch up PHP/JS interactions for inline comments

Summary:
Ref T1460. Overall:

  • Pass objectOwnerPHID consistently.
  • Pass viewer consistently.
  • Set the correct draft state for checkboxes on the client.

Test Plan:

  • Made inline comments in Differential.
  • Made inline comments in Diffusion.

Reviewers: chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T1460

Differential Revision: https://secure.phabricator.com/D12186

Details

Committed
epriestley <git@epriestley.com>Mar 28 2015, 01:08
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb56001457785: Revamp inline commenting UI
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa17542ab28c2: Touch up PHP/JS interactions for inline comments (authored by epriestley <git@epriestley.com>).Mar 28 2015, 01:08