Homec4science

Fix `security.require-https` by marking redirect as external

Authored by James Rhodes <jrhodes@redpointsoftware.com.au> on Aug 21 2014, 13:35.

Description

Fix security.require-https by marking redirect as external

Summary:
Resolves T5937. HTTPS redirects caused by security.require-https use a full scheme, domain and port in the URI. Consequently, this causes invocation of the new external redirect logic and prevents redirection from occurring properly when accessing the HTTP version of Phabricator that has security.require-https turned on.

I've also fixed the automatic slash redirection logic to add the external flag where appropriate.

Test Plan: Configured SSL on my local machine and turned on security.require-https. Observed the "Refusing to redirect" exception on master, while the redirect completed successfully with this patch.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Maniphest Tasks: T5937

Differential Revision: https://secure.phabricator.com/D10318

Details

Committed
James Rhodes <jrhodes@redpointsoftware.com.au>Aug 21 2014, 13:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1ffa16aa6b38: Fix invalid redirect when issuing actions on buildables
Branches
Unknown
Tags
Unknown

Event Timeline

James Rhodes <jrhodes@redpointsoftware.com.au> committed rPHa2a0f002f069: Fix `security.require-https` by marking redirect as external (authored by James Rhodes <jrhodes@redpointsoftware.com.au>).Aug 21 2014, 13:35