Homec4science

Show the difference between a committer and an author

Authored by Hafsteinn Baldvinsson <hsb@group.is> on May 23 2012, 17:34.

Description

Show the difference between a committer and an author

Summary:
Git and hg (supposedly..) differentiate between an author (who wrote the patch)
and a committer (who applied the patch).

This patch allows Phabricator to note when a patch is committed
by someone other than the Author.

Test Plan:
Created 2 accounts,

  • U (Account with a PHID)
  • U' (Account without a PHID)

and had them create and commit commits

testing if their username/real name would be displayed correctly in Diffusion,

  • BrowserTable
  • HistoryTable
  • Code revision

Teztz,
A(uthor)/C(ommitter)
If it's A/A then Author committed

UL = User link (<a href="/p/username">username</a>)
UN = User name ("Firstname Lastname")

Tezt | Expected in table | Got

A/A | UL/UL | UL/UL
A'/C | UN/UL | UN/UL
A/C' | UL/UN | UL/UN
A'/C' | UN/UN | UN/UN

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Koolvin

Maniphest Tasks: T688

Differential Revision: https://secure.phabricator.com/D2541

Details

Committed
epriestley <git@epriestley.com>May 23 2012, 17:34
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe4e56bb431e9: Return partial differential fields when there's an error parsing
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa438c87c52f7: Show the difference between a committer and an author (authored by Hafsteinn Baldvinsson <hsb@group.is>).May 23 2012, 17:34