Homec4science

Return partial differential fields when there's an error parsing

Authored by Nick Harper <nharper@fb.com> on May 23 2012, 02:47.

Description

Return partial differential fields when there's an error parsing

Summary:
If someone typos one name in a cc or reviewer list, it would be nice if we
display all of the valid names in the field when running arc diff (in addition
to the error message).

Test Plan:
used the conduit console to check that calling differential.parsecommitmessage
with a list of some valid and some invalid ccs returns a result with both an
error and a list of some ccs. Also ran arc diff with that list of ccs to check
for the correct user experience.

Reviewers: epriestley, jungejason, vrana

Reviewed By: epriestley

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2542

Details

Committed
Nick Harper <nharper@fb.com>May 23 2012, 03:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHccd37afab860: Attach commit diff to its revision
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPHe4e56bb431e9: Return partial differential fields when there's an error parsing (authored by Nick Harper <nharper@fb.com>).May 23 2012, 03:12