Homec4science

Fix a race condition with the chat column

Authored by epriestley <git@epriestley.com> on Mar 28 2015, 23:46.

Description

Fix a race condition with the chat column

Summary:
Ref T7062. When we load a thread, we always show the column, even if it has been closed between the time we sent the request and when we're processing the response.

Normally this isn't a big deal, but it can specifically show up on mobile.

(This load also shouldn't be happening at all, but I'll fix that separately.)

Test Plan: Mobile no longer shows the column after it loads.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T7062

Differential Revision: https://secure.phabricator.com/D12195

Details

Committed
epriestley <git@epriestley.com>Mar 28 2015, 23:46
Pushed
aubortJan 31 2017, 17:16
Parents
rPH29beb174d3b1: Don't treat Quicksand requests as isWorkflow() or isAjax()
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHa48b486344f6: Fix a race condition with the chat column (authored by epriestley <git@epriestley.com>).Mar 28 2015, 23:46