Homec4science

Add "stop on redirect" and "always profile" debugging options

Authored by epriestley <git@epriestley.com> on Jul 17 2012, 21:06.

Description

Add "stop on redirect" and "always profile" debugging options

Summary:
Currently, it's hard to debug performance issues on POST pages. Add flags to stop redirects and always collect profiles.

Also fix an issue with "all" profiles. This feature is mostly just for profiling DarkConsole itself and is rarely used, I think it's been broken for some time. There's no way to get to it with the UI.

NOTE: Some JS workflows don't stop on redirect because they use JS/AJAX redirects.

Test Plan: Enabled options, browsed, got stopped on redirects and had profiles generated. Disabled options and verified redirects and profiles work normally.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D2990

Details

Committed
epriestley <git@epriestley.com>Jul 17 2012, 21:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9d26ef424854: Improve `differential.createinline`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHae2e73ce809f: Add "stop on redirect" and "always profile" debugging options (authored by epriestley <git@epriestley.com>).Jul 17 2012, 21:06