Homec4science

Don't require edit capability on the Favorites application to edit personal…

Authored by epriestley <git@epriestley.com> on Jan 19 2017, 20:06.

Description

Don't require edit capability on the Favorites application to edit personal menu items

Summary:
Ref T11096. Currently, editing ProfileMenuItemConfigurations always requires that you can edit the corresponding object.

This is correct for global items (for example: you can't change the global menu for a project unless you can edit the project) but not for personal items.

For personal items, only require that the user can edit the customPHID object. Today, this is always their own profile.

Test Plan: As a non-admin, edited personal menu items.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11096

Differential Revision: https://secure.phabricator.com/D17228

Details

Committed
epriestley <git@epriestley.com>Jan 19 2017, 20:15
Pushed
aubortJan 31 2017, 17:16
Parents
rPH269dd81f9178: Allow users to re-accept or re-reject a revision if they have authority over…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb0dfd42eef29: Don't require edit capability on the Favorites application to edit personal… (authored by epriestley <git@epriestley.com>).Jan 19 2017, 20:15