Homec4science

Port comments through time and space in the common/best case

Authored by epriestley <git@epriestley.com> on Apr 21 2015, 00:06.

Description

Port comments through time and space in the common/best case

Summary:
Ref T7447. This ports comments forward and backward in the best case:

  • The old comment is on a changeset with the same filename.
  • The old and new files are pretty much the same, line-for-line.

This will fail to port a lot of comments around and probably port a lot of comments into goofy places. We can see how bad it is in practice.

Errata:

  • Design is me cobbling something together, probably worth tweaking.
  • "Old Comment" should, at a minimum, say "Newer Comment" sometimes, or we should come up with some better name for this stuff.

Test Plan: {F377214}

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: johnny-bit, yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D12484

Details

Committed
epriestley <git@epriestley.com>Apr 21 2015, 20:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5645a07d9984: Modernize DifferentialInlineCommentQuery
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb2d280ff5142: Port comments through time and space in the common/best case (authored by epriestley <git@epriestley.com>).Apr 21 2015, 20:06