Homec4science

Fix several error handling issues with Subversion commits in Diffusion

Authored by epriestley <git@epriestley.com> on Oct 6 2015, 00:57.

Description

Fix several error handling issues with Subversion commits in Diffusion

Summary:
Ref T9513. I checked this briefly but didn't do a very thorough job of it.

  • Don't try to query merges for Subversion, since it doesn't support them.
  • Fix up "existsquery" to work properly (and efficiently) for both hosted and imported repositories.
  • Fix up "parentsquery" to have similar behavior on invalid commits to other VCSes (throw an exception).

Test Plan:

  • No more merges warning on SVN.
  • Hosted SVN gets the right exists result now.
  • Visiting "r23980283789287" now 404's instead of "not parsed yet".

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9513

Differential Revision: https://secure.phabricator.com/D14239

Details

Committed
epriestley <git@epriestley.com>Oct 6 2015, 00:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPHde2bbfef7d14: Allow PhabricatorWorker->queueTask() to take full $options
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb2e89a9e4876: Fix several error handling issues with Subversion commits in Diffusion (authored by epriestley <git@epriestley.com>).Oct 6 2015, 00:57