Homec4science

Filter nonvisible inlines out of changeset inline result set

Authored by epriestley <git@epriestley.com> on Apr 21 2015, 14:36.

Description

Filter nonvisible inlines out of changeset inline result set

Summary:
Ref T7447. After compiling inlines which will appear on the changeset, remove inlines which

Later stages remove these anyway, so it doesn't change anything to keep them around, but we can filter them out here cheaply.

This will also let us drive the Differential timeline view with the same logic a few diffs from now, to improve how it renders inlines. Generalize things a little bit.

Test Plan:

  • Made a comment on the left of diff 1.
  • Made diff 2.
  • Viewed diff 2 vs diff 1.
  • Verified old-left comment was filtered out by the new loop.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D12488

Details

Committed
epriestley <git@epriestley.com>Apr 21 2015, 20:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb2d280ff5142: Port comments through time and space in the common/best case
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHb74bb0019eb5: Filter nonvisible inlines out of changeset inline result set (authored by epriestley <git@epriestley.com>).Apr 21 2015, 20:06