Homec4science

Returning simple text error message instead of HTML for requests where HTML…

Authored by indiefan <indiefan@gmail.com> on Jan 30 2013, 17:11.

Description

Returning simple text error message instead of HTML for requests where HTML won't be rendered for the user. Fixes T2401.

Summary: If the check is too much, let me know. I noticed you send over ajax=true, so I figured it was safest to evaluate existance and value.

Test Plan: Included unit test. Would have included a test where ajax and conduit are not set, but without mocking this gives an uncatchable Fatal Error. If you want me to include it, just direct me on the mocking strategy.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T2401

Differential Revision: https://secure.phabricator.com/D4719

Details

Committed
epriestley <git@epriestley.com>Jan 30 2013, 17:43
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7c5f0250a667: Conpherence - make empty comment submission behave like other apps
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbdecadfd119e: Returning simple text error message instead of HTML for requests where HTML… (authored by indiefan <indiefan@gmail.com>).Jan 30 2013, 17:43