Homec4science

When commits have a "rewritten" hint, try to show that in handles in other…

Authored by epriestley <git@epriestley.com> on Aug 24 2016, 15:24.

Description

When commits have a "rewritten" hint, try to show that in handles in other applications

Summary:
Ref T11522. This tries to reduce the cost of rewriting a repository by making handles smarter about rewritten commits.

When a handle references an unreachable commit, try to load a rewrite hint for the commit. If we find one, change the handle name to "OldHash > NewHash" to provide a strong hint that the commit was rewritten and that copy/pasting the old hash (say, to the CLI) won't work.

I think this notation isn't totally self-evident, but users can click it to see the big error message on the page, and it's at least obvious that something weird is going on, which I think is the important part.

Some possible future work:

  • Not sure this ("Recycling Symbol") is the best symbol? Seems sort of reasonable but mabye there's a better one.
  • Putting this information directly on the hovercard could help explain what this means.

Test Plan: {F1780719}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11522

Differential Revision: https://secure.phabricator.com/D16437

Details

Committed
epriestley <git@epriestley.com>Aug 24 2016, 18:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPH498fb331038c: When a commit has a "rewritten" hint, show it in the UI instead of the generic…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHbe235301d0dc: When commits have a "rewritten" hint, try to show that in handles in other… (authored by epriestley <git@epriestley.com>).Aug 24 2016, 18:35